Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude kourier tls runtime #15696

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Exclude kourier tls runtime #15696

merged 2 commits into from
Jan 15, 2025

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Jan 14, 2025 •
edited
Loading

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 14, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.84%. Comparing base (19b9a09) to head (9c9571d).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15696      +/-   ##
==========================================
+ Coverage   80.78%   80.84%   +0.06%     
==========================================
  Files         222      222              
  Lines       18025    18025              
==========================================
+ Hits        14561    14573      +12     
+ Misses       3092     3082      -10     
+ Partials      372      370       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto skonto force-pushed the disable_kourier_tls branch from fbf111e to 9f896e1 Compare January 14, 2025 17:23
@skonto
Copy link
Contributor Author

skonto commented Jan 14, 2025

/hold
I have seen a failure on 1.31.x too here: https://github.com/knative/serving/actions/runs/12773396668/job/35605270785?pr=15695.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2025
@skonto skonto changed the title Exclude kourier tls runtime on 1.30.x Exclude kourier tls runtime Jan 15, 2025
@skonto
Copy link
Contributor Author

skonto commented Jan 15, 2025

/assign @dprotaso

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2025
@knative-prow knative-prow bot merged commit c3f2bfe into knative:main Jan 15, 2025
62 checks passed
@skonto skonto mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso Awaiting requested review from dprotaso

Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skonto @dprotaso